Into option str #447

Merged
merged 2 commits into from Feb 9, 2017

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Feb 9, 2017

No description provided.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 9, 2017

Member

By way, no "Update gir submodule" here?

Member

EPashkin commented Feb 9, 2017

By way, no "Update gir submodule" here?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 9, 2017

Member

Oups forgot, thanks for the reminder!

Member

GuillaumeGomez commented Feb 9, 2017

Oups forgot, thanks for the reminder!

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 9, 2017

Member

Are the examples built from this PR or from master?

Member

GuillaumeGomez commented Feb 9, 2017

Are the examples built from this PR or from master?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 9, 2017

Member

Well, they seem to work so nevermind.

Member

GuillaumeGomez commented Feb 9, 2017

Well, they seem to work so nevermind.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 9, 2017

Member

Tests passed. Is it ok for you @EPashkin?

Member

GuillaumeGomez commented Feb 9, 2017

Tests passed. Is it ok for you @EPashkin?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 9, 2017

Member

Yes.

Member

EPashkin commented Feb 9, 2017

Yes.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 9, 2017

Member

Great!

Member

GuillaumeGomez commented Feb 9, 2017

Great!

@GuillaumeGomez GuillaumeGomez merged commit 29266f6 into gtk-rs:master Feb 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:into_option_str branch Feb 9, 2017

@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Feb 9, 2017

Contributor

Excellent, thanks @GuillaumeGomez! I just tested this out with my code and everything builds and runs as I'd expect. Looks a lot cleaner now too.

Contributor

Susurrus commented Feb 9, 2017

Excellent, thanks @GuillaumeGomez! I just tested this out with my code and everything builds and runs as I'd expect. Looks a lot cleaner now too.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 9, 2017

Member

Great! :)

Member

GuillaumeGomez commented Feb 9, 2017

Great! :)

@EPashkin EPashkin referenced this pull request Mar 4, 2017

Closed

Make a new release #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment