RadioButton & RadioMenuItem #452

Merged
merged 2 commits into from Feb 20, 2017

Conversation

Projects
None yet
3 participants
@Susurrus
Contributor

Susurrus commented Feb 20, 2017

I went to add the RadioMenuItem and was looking at how to instantiate them, but it didn't make sense given the group argument, which is nullable, is not an Option in the generated code. I then looked at the RadioButton code and it has the same problem. I didn't see any example or reference code that uses RadioButton, so I'm not sure that it's correct. I've "corrected" its autogeneration parameters and added RadioMenuItem, though adding these settings didn't seem to change anything. It seems right based on my understanding of Gir and I see no errors or warning when generating this code.

Gir.toml
+name = "Gtk.RadioButton"
+status = "generate"
+ [[object.function]]
+ name = "new|new_with_label|new_with_mnemonic"

This comment has been minimized.

@EPashkin

EPashkin Feb 20, 2017

Member

This wont work:

@EPashkin

EPashkin Feb 20, 2017

Member

This wont work:

Susurrus added some commits Feb 20, 2017

@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Feb 20, 2017

Contributor

@EPashkin I've regenerated then with what should be necessary then, just adding RadioMenuItem.

Contributor

Susurrus commented Feb 20, 2017

@EPashkin I've regenerated then with what should be necessary then, just adding RadioMenuItem.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Feb 20, 2017

Member

👍 from me

Member

EPashkin commented Feb 20, 2017

👍 from me

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 20, 2017

Member

Thanks!

Member

GuillaumeGomez commented Feb 20, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 193ae54 into gtk-rs:master Feb 20, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Susurrus

This comment has been minimized.

Show comment
Hide comment
@Susurrus

Susurrus Feb 20, 2017

Contributor

One problem with this PR that I forgot to mention is that no docs are generated for gtk::RadioMenuItem. This is especially problematic given that it's not clear from the regular GTK+ docs how to create a RadioMenuItem widget since the group argument isn't an Option. I didn't even think to pass an empty list. So is there something I missed in this PR that needed to be done to get the docs from GTK+ added? And additionally is there an easy way to modify those docs such that they'll talk about the empty list for group instead of NULL?

Contributor

Susurrus commented Feb 20, 2017

One problem with this PR that I forgot to mention is that no docs are generated for gtk::RadioMenuItem. This is especially problematic given that it's not clear from the regular GTK+ docs how to create a RadioMenuItem widget since the group argument isn't an Option. I didn't even think to pass an empty list. So is there something I missed in this PR that needed to be done to get the docs from GTK+ added? And additionally is there an easy way to modify those docs such that they'll talk about the empty list for group instead of NULL?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Feb 20, 2017

Member

Euh... That's actually a good question.

Member

GuillaumeGomez commented Feb 20, 2017

Euh... That's actually a good question.

@EPashkin EPashkin referenced this pull request Mar 4, 2017

Closed

Make a new release #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment