New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing child properties for Box #481

Merged
merged 1 commit into from Apr 1, 2017

Conversation

Projects
None yet
3 participants
@antoyo
Member

antoyo commented Mar 31, 2017

The example will follow soon as a pull request of the examples repository.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 31, 2017

Member

Box already has set_child_packing and query_child_packing so IMHO this properties unneeded.

Member

EPashkin commented Mar 31, 2017

Box already has set_child_packing and query_child_packing so IMHO this properties unneeded.

@antoyo

This comment has been minimized.

Show comment
Hide comment
@antoyo

antoyo Mar 31, 2017

Member

The reason why I added these is that I created a crate called relm and this allows to set child properties individually like in this example.
This code generates the call to set_child_fill for instance.

Member

antoyo commented Mar 31, 2017

The reason why I added these is that I created a crate called relm and this allows to set child properties individually like in this example.
This code generates the call to set_child_fill for instance.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 31, 2017

Member

Ok, then I don't against adding these

Member

EPashkin commented Mar 31, 2017

Ok, then I don't against adding these

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Mar 31, 2017

Member

But rebuild it with Gir b7f5189 or add update gir submodule here

Member

EPashkin commented Mar 31, 2017

But rebuild it with Gir b7f5189 or add update gir submodule here

@antoyo

This comment has been minimized.

Show comment
Hide comment
@antoyo

antoyo Apr 1, 2017

Member

I regenerated with this revision.

Member

antoyo commented Apr 1, 2017

I regenerated with this revision.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 1, 2017

Member

Thanks a lot!

Member

GuillaumeGomez commented Apr 1, 2017

Thanks a lot!

@GuillaumeGomez GuillaumeGomez merged commit 7298719 into gtk-rs:master Apr 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment