New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add child properties for gtk::Notebook #496

Merged
merged 1 commit into from Apr 29, 2017

Conversation

Projects
None yet
3 participants
@antoyo
Member

antoyo commented Apr 29, 2017

No description provided.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 29, 2017

Member

@EPashkin: I have issues with duplicates in here but the fact is that at least we have a more unified API. So from this point of view, I think it's acceptable.

Member

GuillaumeGomez commented Apr 29, 2017

@EPashkin: I have issues with duplicates in here but the fact is that at least we have a more unified API. So from this point of view, I think it's acceptable.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

@antoyo There to many unneeded changes, please, regenerate it with Gir bf7bd49
As @GuillaumeGomez accept this and it compiles I accept despite objections in #495

Member

EPashkin commented Apr 29, 2017

@antoyo There to many unneeded changes, please, regenerate it with Gir bf7bd49
As @GuillaumeGomez accept this and it compiles I accept despite objections in #495

@antoyo

This comment has been minimized.

Show comment
Hide comment
@antoyo

antoyo Apr 29, 2017

Member

@EPashkin Actually, there are different git hashes in the repository, right now.
Look at these two files:
https://github.com/gtk-rs/gtk/blob/master/src/auto/about_dialog.rs
https://github.com/gtk-rs/gtk/blob/master/src/auto/app_chooser_dialog.rs
If I use the git hash you mentioned, there'll be more modifications.

Member

antoyo commented Apr 29, 2017

@EPashkin Actually, there are different git hashes in the repository, right now.
Look at these two files:
https://github.com/gtk-rs/gtk/blob/master/src/auto/about_dialog.rs
https://github.com/gtk-rs/gtk/blob/master/src/auto/app_chooser_dialog.rs
If I use the git hash you mentioned, there'll be more modifications.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

If you build Git from commit bf7bd49f50755a8d1204a3d13b0e8a743a79f458
only 2 files changed: Gir.toml and src/auto/notebool.rs

Member

EPashkin commented Apr 29, 2017

If you build Git from commit bf7bd49f50755a8d1204a3d13b0e8a743a79f458
only 2 files changed: Gir.toml and src/auto/notebool.rs

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

On windows sometimes build.rs don't run and gir_version.rs don't changed. It can fixed with touching Cargo.toml. IMHO it not issue on linux
But anyway if you build with right Gir then will no other changes (with the exception of first 2 lines)

Member

EPashkin commented Apr 29, 2017

On windows sometimes build.rs don't run and gir_version.rs don't changed. It can fixed with touching Cargo.toml. IMHO it not issue on linux
But anyway if you build with right Gir then will no other changes (with the exception of first 2 lines)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

Also you can try do make in gtk root ;)

Member

EPashkin commented Apr 29, 2017

Also you can try do make in gtk root ;)

@antoyo

This comment has been minimized.

Show comment
Hide comment
@antoyo

antoyo Apr 29, 2017

Member

I've fixed it.
By the way, if you don't want the users to use these new methods (for the reasons you mentioned), perhaps we could add #[doc(hidden)] on top of them.

Member

antoyo commented Apr 29, 2017

I've fixed it.
By the way, if you don't want the users to use these new methods (for the reasons you mentioned), perhaps we could add #[doc(hidden)] on top of them.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

Now I understand why there to many files changes: I do partial regen in #486 as we plan do full regen later.
I forgot that, sorry.
Please remove other files from commit

Member

EPashkin commented Apr 29, 2017

Now I understand why there to many files changes: I do partial regen in #486 as we plan do full regen later.
I forgot that, sorry.
Please remove other files from commit

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

Currently no way adding #[doc(hidden)] but it was good idea

Member

EPashkin commented Apr 29, 2017

Currently no way adding #[doc(hidden)] but it was good idea

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 29, 2017

Member

And could be quite easy to add.

Member

GuillaumeGomez commented Apr 29, 2017

And could be quite easy to add.

@EPashkin EPashkin referenced this pull request Apr 29, 2017

Closed

Add config options to hide function doc #356

3 of 3 tasks complete
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

Added gir issue.

Member

EPashkin commented Apr 29, 2017

Added gir issue.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 29, 2017

Member

Let's make the change in gir first and then please update your code in here @antoyo. :)

Member

GuillaumeGomez commented Apr 29, 2017

Let's make the change in gir first and then please update your code in here @antoyo. :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

As do regen after to next version of gir will do too many changes IMHO better
Just add doc_hidden=true here in Gir.toml and merge this PR

Member

EPashkin commented Apr 29, 2017

As do regen after to next version of gir will do too many changes IMHO better
Just add doc_hidden=true here in Gir.toml and merge this PR

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 29, 2017

Member

@EPashkin: Good point.

@antoyo: Can you update please? :)

Member

GuillaumeGomez commented Apr 29, 2017

@EPashkin: Good point.

@antoyo: Can you update please? :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

Too many hidden docs ;)
@antoyo Please unhide position and tab-label as actually don't have equal direct function

Member

EPashkin commented Apr 29, 2017

Too many hidden docs ;)
@antoyo Please unhide position and tab-label as actually don't have equal direct function

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 29, 2017

Member

I'll be out for a few hours. See you later!

Member

GuillaumeGomez commented Apr 29, 2017

I'll be out for a few hours. See you later!

@antoyo

This comment has been minimized.

Show comment
Hide comment
@antoyo

antoyo Apr 29, 2017

Member

@EPashkin I believe the tab-label can already be set by set_tab_label_text and position by reorder_child.

Member

antoyo commented Apr 29, 2017

@EPashkin I believe the tab-label can already be set by set_tab_label_text and position by reorder_child.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2017

Member

@antoyo You right.
@GuillaumeGomez 👍 for merge

Member

EPashkin commented Apr 29, 2017

@antoyo You right.
@GuillaumeGomez 👍 for merge

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 29, 2017

Member

Thanks to both of you! :)

Member

GuillaumeGomez commented Apr 29, 2017

Thanks to both of you! :)

@GuillaumeGomez GuillaumeGomez merged commit 6927e52 into gtk-rs:master Apr 29, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment