New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate global functions #510

Merged
merged 1 commit into from May 18, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented May 17, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 17, 2017

Member

@GuillaumeGomez Please look at this.
You accept use "namespace.*" as name of object for global functions or better use some other name?

Member

EPashkin commented May 17, 2017

@GuillaumeGomez Please look at this.
You accept use "namespace.*" as name of object for global functions or better use some other name?

Show outdated Hide outdated Gir.toml
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 17, 2017

Member

Yes, this syntax is fine by me. Don't forget to document it please. :)

Member

GuillaumeGomez commented May 17, 2017

Yes, this syntax is fine by me. Don't forget to document it please. :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 17, 2017

Member

Ok.

Member

EPashkin commented May 17, 2017

Ok.

@EPashkin EPashkin changed the title from WIP: Generate global functions to Generate global functions May 18, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 18, 2017

Member

@GuillaumeGomez In this and next related PR's I don't added new reexports and replaced some previously manual function.

Member

EPashkin commented May 18, 2017

@GuillaumeGomez In this and next related PR's I don't added new reexports and replaced some previously manual function.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 18, 2017

Member

Thanks!

Member

GuillaumeGomez commented May 18, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit e41430c into gtk-rs:master May 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:global_funtions branch May 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment