New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use glib::BoolError for gtk::init() and gtk::Application::new() #523

Merged
merged 2 commits into from Jun 6, 2017

Conversation

Projects
None yet
2 participants
@sdroege
Member

sdroege commented Jun 6, 2017

Depends on gtk-rs/glib#179

Also removes the useless ApplicationExtManual trait

sdroege added some commits Jun 6, 2017

Don't define an Ext trait for constructor functions
Constructors always return the concrete type, there's no point in
creating another indirection via the trait.
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 6, 2017

Member

I restarted CIs.

Member

GuillaumeGomez commented Jun 6, 2017

I restarted CIs.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jun 6, 2017

Member

CI seems happy :)

Member

sdroege commented Jun 6, 2017

CI seems happy :)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jun 6, 2017

Member

Then me too. :) Thanks!

Member

GuillaumeGomez commented Jun 6, 2017

Then me too. :) Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 769f8f0 into gtk-rs:master Jun 6, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment