New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New types #538

Merged
merged 2 commits into from Jul 5, 2017

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Jul 4, 2017

With this one, not that much types are remaining. :D

cc @EPashkin

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 5, 2017

Member

Manual part don't needed, Gir can handle it.

[[object.function.parameter]]
    name = "region"
    const = true
Member

EPashkin commented Jul 5, 2017

Manual part don't needed, Gir can handle it.

[[object.function.parameter]]
    name = "region"
    const = true
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 5, 2017

Member

Updated.

Member

GuillaumeGomez commented Jul 5, 2017

Updated.

Show outdated Hide outdated Gir.toml
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 5, 2017

Member

Other that small nit LGFM. Thanks

Member

EPashkin commented Jul 5, 2017

Other that small nit LGFM. Thanks

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 5, 2017

Member

Just waiting for CIs (just in case...).

Member

GuillaumeGomez commented Jul 5, 2017

Just waiting for CIs (just in case...).

Show outdated Hide outdated Gir.toml
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 5, 2017

Member

Ok, removed the empty line. Just merging since it seems to be ok. Thanks for the review @EPashkin! :)

Member

GuillaumeGomez commented Jul 5, 2017

Ok, removed the empty line. Just merging since it seems to be ok. Thanks for the review @EPashkin! :)

@GuillaumeGomez GuillaumeGomez merged commit bdf8319 into gtk-rs:master Jul 5, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:new-types branch Jul 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment