New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate lengths parameters #546

Merged
merged 3 commits into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Jul 27, 2017

Apply of gtk-rs/gir#418
Closes #477

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 27, 2017

Member

cc @GuillaumeGomez , @sdroege Replaced manual functions with generated.
Only last it to add "gir submodule update"

cc @Susurrus too as it closes #477

Member

EPashkin commented Jul 27, 2017

cc @GuillaumeGomez , @sdroege Replaced manual functions with generated.
Only last it to add "gir submodule update"

cc @Susurrus too as it closes #477

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 27, 2017

Member

Seems good to me. Waiting for others'.

Member

GuillaumeGomez commented Jul 27, 2017

Seems good to me. Waiting for others'.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 27, 2017

Member

Looks good

Member

sdroege commented Jul 27, 2017

Looks good

@EPashkin EPashkin referenced this pull request Jul 27, 2017

Merged

Fix set_text usage #139

@EPashkin EPashkin changed the title from WIP: Calculate lengths parameters to Calculate lengths parameters Jul 27, 2017

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 27, 2017

Member

@GuillaumeGomez Updated to last gir, better merge this after or simultaneously with gtk-rs/examples#139 or we have constant build failures

Member

EPashkin commented Jul 27, 2017

@GuillaumeGomez Updated to last gir, better merge this after or simultaneously with gtk-rs/examples#139 or we have constant build failures

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 27, 2017

Member

I'll just merge both at once. Thanks!

Member

GuillaumeGomez commented Jul 27, 2017

I'll just merge both at once. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 37bc240 into gtk-rs:master Jul 27, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@EPashkin EPashkin deleted the EPashkin:string_lengths branch Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment