New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate with latest gir, rename ApplicationExt to GtkApplicationEx… #551

Merged
merged 1 commit into from Aug 7, 2017

Conversation

Projects
None yet
3 participants
@sdroege
Member

sdroege commented Aug 7, 2017

…t and ignore clippy warnings in generated code

Regenerate with latest gir, rename ApplicationExt to GtkApplicationEx…
…t and ignore clippy warnings in generated code
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Aug 7, 2017

Member

There are lots of clippy warnings in the manual code, but I don't have time to go through these now

Member

sdroege commented Aug 7, 2017

There are lots of clippy warnings in the manual code, but I don't have time to go through these now

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 7, 2017

Member

I'll write a patch for them in gir I think. Is it ok for you @EPashkin?

Member

GuillaumeGomez commented Aug 7, 2017

I'll write a patch for them in gir I think. Is it ok for you @EPashkin?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 7, 2017

Member

I'll write a patch for them in gir I think.

@sdroege You planning update gir to fix clippy warnings in manual code?

Member

EPashkin commented Aug 7, 2017

I'll write a patch for them in gir I think.

@sdroege You planning update gir to fix clippy warnings in manual code?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 7, 2017

Member

Sorry, I misread sender, question meant for @GuillaumeGomez

Member

EPashkin commented Aug 7, 2017

Sorry, I misread sender, question meant for @GuillaumeGomez

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 7, 2017

Member

Aren't the clippy warnings for the generated code?

Member

GuillaumeGomez commented Aug 7, 2017

Aren't the clippy warnings for the generated code?

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Aug 7, 2017

Member

The ones for the generated code are all gone after you merged this PR. Only the ones in the manual code are left afterwards.

Member

sdroege commented Aug 7, 2017

The ones for the generated code are all gone after you merged this PR. Only the ones in the manual code are left afterwards.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 7, 2017

Member

Ah I see. Well, I'll fix them this evening then. Thanks!

Member

GuillaumeGomez commented Aug 7, 2017

Ah I see. Well, I'll fix them this evening then. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 792b334 into gtk-rs:master Aug 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment