New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #552

Merged
merged 2 commits into from Aug 8, 2017

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Aug 7, 2017

Seems strange but didn't have any warnings or anything... So let's see with travis.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 7, 2017

Member

If was for cargo clippy

Member

EPashkin commented Aug 7, 2017

If was for cargo clippy

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 7, 2017

Member

Ah we don't run it on travis? I thought we did... Fixing warnings then.

Member

GuillaumeGomez commented Aug 7, 2017

Ah we don't run it on travis? I thought we did... Fixing warnings then.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 7, 2017

Member

Clippy still don't shipped with rust (but planned) and still need nightly, so we can't add it to stables.

Member

EPashkin commented Aug 7, 2017

Clippy still don't shipped with rust (but planned) and still need nightly, so we can't add it to stables.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 7, 2017

Member

Oh that's not an issue. I added it to some of my projects which test both stable and nightly (I'm thinking about sysinfo and process-viewer). I just test clippy and nightly and don't call on stable. Nothing magical but very convenient.

Member

GuillaumeGomez commented Aug 7, 2017

Oh that's not an issue. I added it to some of my projects which test both stable and nightly (I'm thinking about sysinfo and process-viewer). I just test clippy and nightly and don't call on stable. Nothing magical but very convenient.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 7, 2017

Member

Updated.

Member

GuillaumeGomez commented Aug 7, 2017

Updated.

Show outdated Hide outdated src/lib.rs
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 7, 2017

Member

@GuillaumeGomez, interesting idea, maybe really apply it on gtk too?

Member

EPashkin commented Aug 7, 2017

@GuillaumeGomez, interesting idea, maybe really apply it on gtk too?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 7, 2017

Member

Sure, I'll add it to this PR.

Member

GuillaumeGomez commented Aug 7, 2017

Sure, I'll add it to this PR.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 7, 2017

Member

And here you go. We now have cargo clippy check on nightly.

Member

GuillaumeGomez commented Aug 7, 2017

And here you go. We now have cargo clippy check on nightly.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 8, 2017

Member

@GuillaumeGomez Thanks, 👍 with changing PR title.

Member

EPashkin commented Aug 8, 2017

@GuillaumeGomez Thanks, 👍 with changing PR title.

@GuillaumeGomez GuillaumeGomez changed the title from Remove useless allows to Fix clippy warnings Aug 8, 2017

@GuillaumeGomez GuillaumeGomez merged commit d3fb356 into gtk-rs:master Aug 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:useless-allows branch Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment