New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check fixed #566

Merged
merged 3 commits into from Aug 27, 2017

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Aug 27, 2017

Fixes #565.

cc @EPashkin

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 27, 2017

Member

I prefer look C code first and fix upstream, but currently don't have time.
Also not sure that need fix ASAP as it case wrong use.

Member

EPashkin commented Aug 27, 2017

I prefer look C code first and fix upstream, but currently don't have time.
Also not sure that need fix ASAP as it case wrong use.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 27, 2017

Member

Wrong use but it shouldn't segfault, it should panic. Huge difference! But if you have better, please do. :)

Otherwise we're not into a hurry so it can wait.

Member

GuillaumeGomez commented Aug 27, 2017

Wrong use but it shouldn't segfault, it should panic. Huge difference! But if you have better, please do. :)

Otherwise we're not into a hurry so it can wait.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 27, 2017

Member

check_init_asserts failed
also src/fixed.rs don't have mod fixed in lib, and no trait reexport in prelude

Member

EPashkin commented Aug 27, 2017

check_init_asserts failed
also src/fixed.rs don't have mod fixed in lib, and no trait reexport in prelude

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 27, 2017

Member

Ah damn, I forgot to add the missing files.

Member

GuillaumeGomez commented Aug 27, 2017

Ah damn, I forgot to add the missing files.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 27, 2017

Member

Also child properties for "Gtk.Fixed" need be commented

Member

EPashkin commented Aug 27, 2017

Also child properties for "Gtk.Fixed" need be commented

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 27, 2017

Member

*in Gir.toml

Member

EPashkin commented Aug 27, 2017

*in Gir.toml

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 27, 2017

Member

It's done in the update as well. ;)

Member

GuillaumeGomez commented Aug 27, 2017

It's done in the update as well. ;)

Show outdated Hide outdated src/fixed.rs Outdated
Show outdated Hide outdated src/fixed.rs Outdated
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 27, 2017

Member

And please add link to #565 somewhere in fixed.rs

Member

EPashkin commented Aug 27, 2017

And please add link to #565 somewhere in fixed.rs

Show outdated Hide outdated src/fixed.rs Outdated
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 27, 2017

Member

👍 after CI passed

Member

EPashkin commented Aug 27, 2017

👍 after CI passed

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 27, 2017

Member

All updated for good this time!

Member

GuillaumeGomez commented Aug 27, 2017

All updated for good this time!

@GuillaumeGomez GuillaumeGomez merged commit f020c00 into gtk-rs:master Aug 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:check-fixed branch Aug 27, 2017

@serpilliere

This comment has been minimized.

Show comment
Hide comment
@serpilliere

serpilliere commented Aug 27, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment