New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buildable interface #568

Merged
merged 2 commits into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@federicomenaquintero
Contributor

federicomenaquintero commented Aug 28, 2017

No description provided.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 28, 2017

Member

Looks good for me, thanks!

Member

GuillaumeGomez commented Aug 28, 2017

Looks good for me, thanks!

@federicomenaquintero

This comment has been minimized.

Show comment
Hide comment
@federicomenaquintero

federicomenaquintero Aug 28, 2017

Contributor

Oops, I just updated the branch. I had forgotten to put BuildableExtManual in prelude.rs.

Contributor

federicomenaquintero commented Aug 28, 2017

Oops, I just updated the branch. I had forgotten to put BuildableExtManual in prelude.rs.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 28, 2017

Member

As I remember we disable it for some reason, but not remember for what :(

Member

EPashkin commented Aug 28, 2017

As I remember we disable it for some reason, but not remember for what :(

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 28, 2017

Member

Also please regen with right versions of gir and gir-files

Member

EPashkin commented Aug 28, 2017

Also please regen with right versions of gir and gir-files

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Aug 28, 2017

Member

About gtk-rs/glib#219 (comment): this can cause need to specify trait function that need called, Ex. Widget::set_name(&btn, "name") instead btn.set_name("name"),
if this function is infrequently used, then its not big problem.

Member

EPashkin commented Aug 28, 2017

About gtk-rs/glib#219 (comment): this can cause need to specify trait function that need called, Ex. Widget::set_name(&btn, "name") instead btn.set_name("name"),
if this function is infrequently used, then its not big problem.

@federicomenaquintero

This comment has been minimized.

Show comment
Hide comment
@federicomenaquintero

federicomenaquintero Aug 29, 2017

Contributor

Hmmm, I'm not convinced that my git submodules are set up correctly... I just did "make" and that downloaded them. How can I check this?

set_name() is indeed not used very often; it's for styles and themes.

Contributor

federicomenaquintero commented Aug 29, 2017

Hmmm, I'm not convinced that my git submodules are set up correctly... I just did "make" and that downloaded them. How can I check this?

set_name() is indeed not used very often; it's for styles and themes.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Aug 29, 2017

Member

Ah, the dark magic of git submodules! :D

Once they're downloaded:

cd gir
git pull origin master
cd ../gir-files
git pull origin master
cd ..
make gir

Don't forget to commit gir and gir-files.

Member

GuillaumeGomez commented Aug 29, 2017

Ah, the dark magic of git submodules! :D

Once they're downloaded:

cd gir
git pull origin master
cd ../gir-files
git pull origin master
cd ..
make gir

Don't forget to commit gir and gir-files.

federicomenaquintero added some commits Aug 28, 2017

Add the Buildable interface
We put the [gs]et_name() methods in BuildableExtManual since their
names collide with others, e.g. gtk_widget_get_name(),
gtk_file_filter_get_name().
@federicomenaquintero

This comment has been minimized.

Show comment
Hide comment
@federicomenaquintero

federicomenaquintero Nov 16, 2017

Contributor

I've rebased this to master, updated the submodules, and regenerated. Now all the auto/* get the Buildable interface as appropriate.

Contributor

federicomenaquintero commented Nov 16, 2017

I've rebased this to master, updated the submodules, and regenerated. Now all the auto/* get the Buildable interface as appropriate.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez
Member

GuillaumeGomez commented Nov 16, 2017

👍

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 16, 2017

Member

@federicomenaquintero Thanks
👍 too.

Member

EPashkin commented Nov 16, 2017

@federicomenaquintero Thanks
👍 too.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 16, 2017

Member

Just waiting for CIs and then we merge. (please remind me if I forget!)

Member

GuillaumeGomez commented Nov 16, 2017

Just waiting for CIs and then we merge. (please remind me if I forget!)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 16, 2017

Member

I restarted appveyour

Member

EPashkin commented Nov 16, 2017

I restarted appveyour

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 16, 2017

Member

CI passed here too.

Member

EPashkin commented Nov 16, 2017

CI passed here too.

@GuillaumeGomez GuillaumeGomez merged commit 0313b78 into gtk-rs:master Nov 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 16, 2017

Member

Thanks!

Member

GuillaumeGomez commented Nov 16, 2017

Thanks!

@federicomenaquintero

This comment has been minimized.

Show comment
Hide comment
@federicomenaquintero

federicomenaquintero Nov 16, 2017

Contributor

Awesome, thanks!

Contributor

federicomenaquintero commented Nov 16, 2017

Awesome, thanks!

@federicomenaquintero federicomenaquintero deleted the federicomenaquintero:buildable-iface branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment