New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal panic on Image::get_icon_image for images without names #577

Merged
merged 1 commit into from Oct 8, 2017

Conversation

Projects
None yet
3 participants
@EPashkin
Member

EPashkin commented Oct 8, 2017

Ex. created from file

Solves problem in gtk-rs/gir#350 (comment)

cc @GuillaumeGomez, @sdroege

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 8, 2017

Member

As properties generated and works fine and get_property_icon_size also works,
then maybe manual part unneeded?

Member

EPashkin commented Oct 8, 2017

As properties generated and works fine and get_property_icon_size also works,
then maybe manual part unneeded?

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Oct 8, 2017

Member

👍

Member

sdroege commented Oct 8, 2017

👍

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 8, 2017

Member

@sdroege you vote for merge as is or remove manual part?

Member

EPashkin commented Oct 8, 2017

@sdroege you vote for merge as is or remove manual part?

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 8, 2017

Member

I'm all for removing the manual part if unneeded.

Member

GuillaumeGomez commented Oct 8, 2017

I'm all for removing the manual part if unneeded.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Oct 8, 2017

Member

Either way seems fine to me

Member

sdroege commented Oct 8, 2017

Either way seems fine to me

Replace Image::get_icon_image with properties
It panic for images without names Ex. created from file
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 8, 2017

Member

Updated

Member

EPashkin commented Oct 8, 2017

Updated

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Oct 8, 2017

Member

CI passed

Member

EPashkin commented Oct 8, 2017

CI passed

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Oct 8, 2017

Member

Thanks!

Member

GuillaumeGomez commented Oct 8, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 1d9fb9d into gtk-rs:master Oct 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:fix_gtk_image_get_icon_name branch Oct 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment