New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print operation #596

Merged
merged 2 commits into from Nov 26, 2017

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Nov 26, 2017

Closes #595
cc @pwil3058

@GuillaumeGomez This based on #594

EPashkin added some commits Nov 26, 2017

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2017

Member

Is the regen commit still needed?

Member

GuillaumeGomez commented Nov 26, 2017

Is the regen commit still needed?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2017

Member

As 594 merged, only "Generate PrintOperation" will be added

Member

EPashkin commented Nov 26, 2017

As 594 merged, only "Generate PrintOperation" will be added

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2017

Member

That's what I'd think but I'm surprised by the fact the commit is still showing up. Generally, github hides it if it's already merged.

Member

GuillaumeGomez commented Nov 26, 2017

That's what I'd think but I'm surprised by the fact the commit is still showing up. Generally, github hides it if it's already merged.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Nov 26, 2017

Member

IMHO only if it was merged before PR started :(

Member

EPashkin commented Nov 26, 2017

IMHO only if it was merged before PR started :(

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2017

Member

Well, whatever. Once CI passed, I'll merge so it doesn't change much. ;)

Member

GuillaumeGomez commented Nov 26, 2017

Well, whatever. Once CI passed, I'll merge so it doesn't change much. ;)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Nov 26, 2017

Member

Thanks!

Member

GuillaumeGomez commented Nov 26, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit e6cbcea into gtk-rs:master Nov 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:PrintOperation branch Nov 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment