New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version for Gtk.StyleContextPrintFlags #603

Merged
merged 2 commits into from Dec 3, 2017

Conversation

Projects
None yet
3 participants
@gbip
Contributor

gbip commented Dec 3, 2017

Change requested in #600.

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 3, 2017

Sorry, but you do wrong changes:
Removing "Gtk.StyleContextPrintFlags" from generate array is right,
but change version for Gtk.StyleContext is not.
you need add generate flags with version

[[object]]
name = "Gtk.StyleContextPrintFlags"
status = "generate"
version = "3.20"
@gbip

This comment has been minimized.

Contributor

gbip commented Dec 3, 2017

Woops sorry I went too fast on this one, my bad.

Gir.toml Outdated
@@ -1332,6 +1331,13 @@ status = "generate"
name = "paint-clock"
version = "3.8"

This comment has been minimized.

@EPashkin

EPashkin Dec 3, 2017

Member

Please remove 2 empty lines

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 3, 2017

Good, only small nit

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 3, 2017

@gbip Thanks, just waiting for CI

@EPashkin

This comment has been minimized.

Member

EPashkin commented Dec 3, 2017

@GuillaumeGomez Please take look at this PR.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Dec 3, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 6726936 into gtk-rs:master Dec 3, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment