Skip to content
This repository was archived by the owner on Jun 8, 2021. It is now read-only.

Change version for Gtk.StyleContextPrintFlags#603

Merged
GuillaumeGomez merged 2 commits intogtk-rs:masterfrom
gbip:master
Dec 3, 2017
Merged

Change version for Gtk.StyleContextPrintFlags#603
GuillaumeGomez merged 2 commits intogtk-rs:masterfrom
gbip:master

Conversation

@gbip
Copy link
Copy Markdown
Contributor

@gbip gbip commented Dec 3, 2017

Change requested in #600.

@EPashkin
Copy link
Copy Markdown
Member

EPashkin commented Dec 3, 2017

Sorry, but you do wrong changes:
Removing "Gtk.StyleContextPrintFlags" from generate array is right,
but change version for Gtk.StyleContext is not.
you need add generate flags with version

[[object]]
name = "Gtk.StyleContextPrintFlags"
status = "generate"
version = "3.20"

@gbip
Copy link
Copy Markdown
Contributor Author

gbip commented Dec 3, 2017

Woops sorry I went too fast on this one, my bad.

EPashkin
EPashkin reviewed Dec 3, 2017
View reviewed changes
Comment thread Gir.toml Outdated
version = "3.8"



Copy link
Copy Markdown
Member

@EPashkin EPashkin Dec 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove 2 empty lines

@EPashkin
Copy link
Copy Markdown
Member

EPashkin commented Dec 3, 2017

Good, only small nit

@EPashkin
Copy link
Copy Markdown
Member

EPashkin commented Dec 3, 2017

@gbip Thanks, just waiting for CI

@EPashkin
Copy link
Copy Markdown
Member

EPashkin commented Dec 3, 2017

@GuillaumeGomez Please take look at this PR.

@GuillaumeGomez
Copy link
Copy Markdown
Member

GuillaumeGomez commented Dec 3, 2017

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 6726936 into gtk-rs:master Dec 3, 2017
This was referenced Feb 19, 2018
Closed
Merged
@EPashkin EPashkin mentioned this pull request May 3, 2018
Closed
alex179ohm pushed a commit to alex179ohm/gtk that referenced this pull request Oct 21, 2019
@EPashkin
Merge pull request gtk-rs#603 from EPashkin/fix_out_parameter_type
47ba509 
Fix generating function body when out parameter has reserved name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@EPashkin EPashkin EPashkin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gbip @EPashkin @GuillaumeGomez