New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regen for Gtk 3.22.26 #620

Merged
merged 3 commits into from Feb 4, 2018

Conversation

Projects
None yet
2 participants
@EPashkin
Member

EPashkin commented Feb 3, 2018

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 3, 2018

👍

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 3, 2018

There possible problem with new functions and enum cases: it don't have version too.
Maybe I need add it?

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 3, 2018

Their version isn't generated? Is the information missing in the gir files or is gir failing to generate the cfg condition?

@@ -428,6 +428,8 @@ bitflags! {
const UPPERCASE_SENTENCES = 64;
const INHIBIT_OSK = 128;
const VERTICAL_WRITING = 256;
const EMOJI = 512;
const NO_EMOJI = 1024;

This comment has been minimized.

@EPashkin

EPashkin Feb 3, 2018

Member

This added without version in Gtk-3.0.gir

fn emit_insert_emoji(&self) {
let _ = self.emit("insert-emoji", &[]).unwrap();
}

This comment has been minimized.

@EPashkin

EPashkin Feb 3, 2018

Member

This too

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 3, 2018

Added i32 to ResponseType and IconSize conversion

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 3, 2018

@GuillaumeGomez These same problem in bitfield gdk::WindowState TOP_TILED and other 7 added without version in Gdk-3.0.gir

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 3, 2018

So I suppose we need a manual fix. Should we add a version = "x.x.x" in the toml file?

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 3, 2018

Yes, I add it to gtk and gdk

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 3, 2018

Thanks!

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 3, 2018

Updated as separate commit

@EPashkin

This comment has been minimized.

Member

EPashkin commented Feb 3, 2018

Don't know how to do with gdk part: source says "GDK_WINDOW_STATE_TOP_TILED: whether the top edge is tiled, Since 3.91.2"
Version too big. As I remember it beta for 4.0 but this IMHO still not published.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 3, 2018

Let's just ignore it then. Kinda weird though.

@GuillaumeGomez

This comment has been minimized.

Member

GuillaumeGomez commented Feb 4, 2018

Ok, now seems good to me. Thanks @EPashkin!

@GuillaumeGomez GuillaumeGomez merged commit 406a5c6 into gtk-rs:master Feb 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:regen_with_v3.22.26 branch Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment