New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix present method on macos #651

Merged
merged 1 commit into from Apr 29, 2018

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Apr 29, 2018

Show outdated Hide outdated src/lib.rs
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2018

Member

@sdroege Examples failed build second time. Any idea?

error: custom attribute panicked
  --> src/bin/gio_futures_await.rs:23:1
   |
23 | #[async]
   | ^^^^^^^^
   |
   = help: message: unsupported character _
Member

EPashkin commented Apr 29, 2018

@sdroege Examples failed build second time. Any idea?

error: custom attribute panicked
  --> src/bin/gio_futures_await.rs:23:1
   |
23 | #[async]
   | ^^^^^^^^
   |
   = help: message: unsupported character _
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 29, 2018

Member

Bug in nightly of today, see rust-lang-nursery/futures-rs#992

Member

sdroege commented Apr 29, 2018

Bug in nightly of today, see rust-lang-nursery/futures-rs#992

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 29, 2018

Member

Can you explain why this is necessary and correct? And please link to the relevant GTK bug in Bugzilla, or create one if none exists. This looks very ugly and needs at least an explanation in the code

Member

sdroege commented Apr 29, 2018

Can you explain why this is necessary and correct? And please link to the relevant GTK bug in Bugzilla, or create one if none exists. This looks very ugly and needs at least an explanation in the code

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Apr 29, 2018

Member

@sdroege So we can ignore it now, Thanks.

Member

EPashkin commented Apr 29, 2018

@sdroege So we can ignore it now, Thanks.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 29, 2018

Member

Can you explain why this is necessary and correct? And please link to the relevant GTK bug in Bugzilla, or create one if none exists. This looks very ugly and needs at least an explanation in the code

Because on OSX, this function doesn't bring the window to the foreground whereas it should. As simple as that. I found the bug in bugzilla but can't it again...

Member

GuillaumeGomez commented Apr 29, 2018

Can you explain why this is necessary and correct? And please link to the relevant GTK bug in Bugzilla, or create one if none exists. This looks very ugly and needs at least an explanation in the code

Because on OSX, this function doesn't bring the window to the foreground whereas it should. As simple as that. I found the bug in bugzilla but can't it again...

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Apr 29, 2018

Member

please find it again so we can properly link it here :) It's important so that we can remove this ugly workaround once we depend on a new enough GTK, and so our futures selfes can later understand how this disaster of code happened

Member

sdroege commented Apr 29, 2018

please find it again so we can properly link it here :) It's important so that we can remove this ugly workaround once we depend on a new enough GTK, and so our futures selfes can later understand how this disaster of code happened

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Apr 29, 2018

Member

For reference, bug is referenced here.

Member

GuillaumeGomez commented Apr 29, 2018

For reference, bug is referenced here.

@GuillaumeGomez GuillaumeGomez merged commit 1ca32b4 into gtk-rs:master Apr 29, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:fix-present branch Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment