New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version for Gtk.TextViewLayer #654

Merged
merged 2 commits into from May 3, 2018

Conversation

Projects
None yet
3 participants
@foo-jin
Contributor

foo-jin commented May 3, 2018

The fix as suggested in #653.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 3, 2018

Member

Strange, I don't see a version requirement for this enum in the gtk docs...

Member

GuillaumeGomez commented May 3, 2018

Strange, I don't see a version requirement for this enum in the gtk docs...

[[object]]
name = "Gtk.TextViewLayer"
status = "generate"
version = "3.14"

This comment has been minimized.

@EPashkin

EPashkin May 3, 2018

Member

Please, move this between Gtk.TextView and Gtk.Toolbar.

@EPashkin

EPashkin May 3, 2018

Member

Please, move this between Gtk.TextView and Gtk.Toolbar.

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez May 3, 2018

Member

We should add a test to enforce that it's alpha sorted in the toml file. I'm going to add when I have a bit of time. :)

@GuillaumeGomez

GuillaumeGomez May 3, 2018

Member

We should add a test to enforce that it's alpha sorted in the toml file. I'm going to add when I have a bit of time. :)

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 3, 2018

Member

@GuillaumeGomez Yes no version in docs, but enum not present in 3.10 libs and used only in internal GtkTextViewClass.draw_layer, so it safe to say that it added with it.

Member

EPashkin commented May 3, 2018

@GuillaumeGomez Yes no version in docs, but enum not present in 3.10 libs and used only in internal GtkTextViewClass.draw_layer, so it safe to say that it added with it.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 3, 2018

Member

That's weird... But whatever, let's merge it then! Thanks!

Member

GuillaumeGomez commented May 3, 2018

That's weird... But whatever, let's merge it then! Thanks!

@GuillaumeGomez GuillaumeGomez merged commit ac7f0eb into gtk-rs:crate May 3, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 3, 2018

Member

Hm, missed that it not against master.
I will repeat on master

Member

EPashkin commented May 3, 2018

Hm, missed that it not against master.
I will repeat on master

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 3, 2018

Member

Wait what?! Oh damn! I remove the commit from history.

Member

GuillaumeGomez commented May 3, 2018

Wait what?! Oh damn! I remove the commit from history.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 3, 2018

Member

Ok done. Please reopen it against the master branch (or maybe not needed if @EPashkin does it?).

Member

GuillaumeGomez commented May 3, 2018

Ok done. Please reopen it against the master branch (or maybe not needed if @EPashkin does it?).

@EPashkin EPashkin referenced this pull request May 3, 2018

Merged

Text view layer version #655

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 3, 2018

Member

@foo-jin I replaced PR. Thanks for reporting problem.

Member

EPashkin commented May 3, 2018

@foo-jin I replaced PR. Thanks for reporting problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment