New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let applicationwindow accept anything implementing Application #659

Merged
merged 1 commit into from May 8, 2018

Conversation

Projects
None yet
5 participants
@vhdirk

vhdirk commented May 8, 2018

As mentioned in gtk-rs/gtk#658, gtk::ApplicationWindow should accept anything that IsAgtk::Application.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 8, 2018

Member

Sounds good to me. @sdroege, @EPashkin is it good if I merge this one while we try to fix the issue in gir?

Member

GuillaumeGomez commented May 8, 2018

Sounds good to me. @sdroege, @EPashkin is it good if I merge this one while we try to fix the issue in gir?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 8, 2018

Member

@vhdirk Thanks.
@GuillaumeGomez Yes, It better use manual function now.
Travis already has 2 nigthly failure: first on clippy, second stall on building clippy.
This failures IMHO can be ignored.

Member

EPashkin commented May 8, 2018

@vhdirk Thanks.
@GuillaumeGomez Yes, It better use manual function now.
Travis already has 2 nigthly failure: first on clippy, second stall on building clippy.
This failures IMHO can be ignored.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez May 8, 2018

Member

Agree. Thanks @vhdirk!

Member

GuillaumeGomez commented May 8, 2018

Agree. Thanks @vhdirk!

@GuillaumeGomez GuillaumeGomez merged commit 8e14d40 into gtk-rs:master May 8, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege May 8, 2018

Member

@EPashkin Do you know why it's generated wrong?

Member

sdroege commented May 8, 2018

@EPashkin Do you know why it's generated wrong?

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin May 8, 2018

Member

@sdroege Currently don't know, will check after done with OsString

Member

EPashkin commented May 8, 2018

@sdroege Currently don't know, will check after done with OsString

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment