Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget::get_events() / add_events() / set_events() should take a gdk:… #705

Merged
merged 1 commit into from Sep 16, 2018

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Sep 16, 2018

…:EventMask

Fixes #704

ignore = true
[[object.function]]
name = "set_events"
ignore = true

This comment has been minimized.

@EPashkin

EPashkin Sep 16, 2018

Member

property "events" need ignore too.

This comment has been minimized.

@sdroege

sdroege Sep 16, 2018

Author Member

Why? One might want to use the notify signal of it

This comment has been minimized.

@EPashkin

EPashkin Sep 16, 2018

Member

You right, I missed that connect_property_events_notify already generated.
And we don't have way to generate only notify without get/set 😭

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Sep 16, 2018

Member

@EPashkin: I wonder why too. :)

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Sep 16, 2018

Member

Ah damn. Github refreshed after I commented. Now we know why. 😆

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Sep 16, 2018

@sdroege Thanks

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Sep 16, 2018

Thanks! Waiting for CIs now.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Sep 16, 2018

as i32 needed in manual code

@EPashkin

This comment has been minimized.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Sep 16, 2018

Oops, fixed!

@sdroege sdroege force-pushed the sdroege:gdk-eventmask branch from 2884cc8 to f4ad6ff Sep 16, 2018

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Sep 16, 2018

@GuillaumeGomez all green except for spurious travis failure

@GuillaumeGomez GuillaumeGomez merged commit 45a12ec into gtk-rs:master Sep 16, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

vhdirk pushed a commit to vhdirk/gtk-rs that referenced this pull request Jan 16, 2019

Merge pull request gtk-rs#705 from sdroege/gdk-eventmask
Widget::get_events() / add_events() / set_events() should take a gdk:…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.