Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MenuItemExt trait to GtkMenuItemExt #714

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Oct 1, 2018

I completely forgot about this one, shame on me... (I think this is what you tried to say to me @EPashkin, sorry for not understanding ><).

cc @sdroege @EPashkin

@GuillaumeGomez GuillaumeGomez referenced this pull request Oct 1, 2018

Merged

Update to gtk #194

@EPashkin EPashkin referenced this pull request Oct 1, 2018

Closed

Use renamed GtkMenuExt #195

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Oct 1, 2018

I also was wrong, thought that changes need be made in gtk, but actually examples need change: gtk-rs/examples#195

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Oct 1, 2018

👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Oct 1, 2018

Merging this one and we'll see if everything's fixed in the examples PR (otherwise both will fail...).

@GuillaumeGomez GuillaumeGomez merged commit 1a3f271 into gtk-rs:master Oct 1, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:rename-menu-item branch Oct 1, 2018

vhdirk pushed a commit to vhdirk/gtk-rs that referenced this pull request Jan 16, 2019

Merge pull request gtk-rs#714 from GuillaumeGomez/rename-menu-item
Rename MenuItemExt trait to GtkMenuItemExt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.