Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for 1.28 #741

Merged
merged 1 commit into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 15, 2018

No description provided.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 15, 2018

@GuillaumeGomez Seems I missed something. Why you to do this?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Nov 15, 2018

If these files are useless, shouldn't we remove them?

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 15, 2018

This question about replace stable with 1.28 (while PR title says "add")

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Nov 15, 2018

It's a discussion we had with @sdroege: gstreamer is supporting 1.28 (giving you context about all those PRs). But yes, it should be called "replace" instead. Replacing all titles (😭).

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 15, 2018

Ok, now I understand.

@GuillaumeGomez GuillaumeGomez merged commit 175642b into gtk-rs:master Nov 16, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:1_28 branch Nov 16, 2018

vhdirk pushed a commit to vhdirk/gtk-rs that referenced this pull request Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.