Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BoolError constructions #751

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
3 participants
@fengalin
Copy link
Contributor

fengalin commented Jan 4, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 4, 2019

Seems good to me. Thanks!

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 4, 2019

@fengalin Thanks again.
If no changes in generated code, then update sub-modules not needed and only cause nightly CI failure on "make regen_check"

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Jan 4, 2019

@EPashkin, yes of course! Sorry about that.

@fengalin fengalin force-pushed the fengalin:bool_error_from branch from 18590eb to b6a3d9f Jan 4, 2019

@GuillaumeGomez GuillaumeGomez merged commit 6d98274 into gtk-rs:master Jan 4, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@fengalin fengalin deleted the fengalin:bool_error_from branch Jan 4, 2019

vhdirk pushed a commit to vhdirk/gtk-rs that referenced this pull request Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.