Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore some more problematic functions #752

Merged
merged 2 commits into from Jan 6, 2019

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Jan 6, 2019

They all need to be generated by hands.

cc @EPashkin @sdroege

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 6, 2019

@GuillaumeGomez Even after your gtk-rs/gir#667 ?
You will add regen or/and manual implementations in other PR?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jan 6, 2019

The problem for those ones is that it has pointers of pointers. The problem is even before my PR. :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 6, 2019

Now reason is more clear, its preparing for time when closure implemented (as currently functions commented anyway).
Still comments #array with size is misleading for request_targets as no arrays in function definition, (only in its subtype),
also in request_uris type ClipboardURIReceivedFunc don't contains any size,

Still not clear for me if PR is ready for merge or not as it not pass "regen_check"

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jan 6, 2019

That's interesting: setting functions as ignored in this case make them generated (as commented but still). Surprising, no?

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 6, 2019

No, regen_check shows inverse diff, so these commented lines just removed

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jan 6, 2019

Is it expected?

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 6, 2019

Currently it shows changes that "wrongly added" to generated version.
Not fully sure is right or we better show just changes after "right done regen"

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jan 6, 2019

In any case it's a bit surprising since I just ignored some functions that aren't (yet) generated.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jan 6, 2019

I regenerated with current gir.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 6, 2019

👍 , Travis again can't install clippy 😢

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Jan 6, 2019

That's... interesting? XD Thanks for the review, I'll just merge then.

@GuillaumeGomez GuillaumeGomez merged commit 6a0c066 into gtk-rs:master Jan 6, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:fix-gir branch Jan 6, 2019

@@ -678,6 +678,22 @@ status = "generate"
name = "set_can_store"
#array with size
ignore = true
[[object.function]]
name = "request_targets"
#array with size

This comment has been minimized.

@sdroege

sdroege Jan 7, 2019

Member

What's the problem with this? We support that elsewhere just fine and we have conversion traits for this specific case :) from_glib_none_num()

Same for everything else below

This comment has been minimized.

@GuillaumeGomez

GuillaumeGomez Jan 7, 2019

Author Member

Then that means that my gir PR is incomplete. :'(

This comment has been minimized.

@sdroege

sdroege Jan 7, 2019

Member

Indeed :(

vhdirk pushed a commit to vhdirk/gtk-rs that referenced this pull request Jan 16, 2019

Merge pull request gtk-rs#752 from GuillaumeGomez/fix-gir
Ignore some more problematic functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.