Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define manual traits #766

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
2 participants
@EPashkin
Copy link
Member

EPashkin commented Jan 27, 2019

Part of gtk-rs/gir#683

WIP as need update gir submodule

@EPashkin EPashkin referenced this pull request Jan 27, 2019

Merged

Define manual traits #265

@EPashkin EPashkin force-pushed the EPashkin:manual_traits branch 2 times, most recently from 63555a2 to e80f94f Jan 29, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 29, 2019

Removed manual traits that will be removed in #770
Still in WIP until it merged.

@EPashkin EPashkin force-pushed the EPashkin:manual_traits branch from e80f94f to a912947 Jan 31, 2019

@EPashkin EPashkin changed the title WIP: Define manual traits Define manual traits Jan 31, 2019

@EPashkin EPashkin referenced this pull request Jan 31, 2019

Open

Docs don't shows that class implements manual traits #683

1 of 2 tasks complete

@EPashkin EPashkin force-pushed the EPashkin:manual_traits branch from a912947 to f3565bc Jan 31, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Jan 31, 2019

Fixed object order

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 31, 2019

👍

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Feb 1, 2019

CI passed

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 1, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 4d157b7 into gtk-rs:master Feb 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:manual_traits branch Feb 1, 2019

This was referenced Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.