Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-GNU versions of make #771

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
4 participants
@SamWhited
Copy link
Contributor

SamWhited commented Jan 29, 2019

I have bmake (NetBSD's make, which is mostly just POSIX like and doesn't support many GNU-isms) installed on most of my machines. The makefile for this project mostly works, but GIR_SRC wasn't being set correctly because the shell expansion is a GNU-ism.

This sets those files in a more standard way that other versions of Make (including GNU's) will also pick up on.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 29, 2019

GIR_SRC != find gir/src -name '*.rs' doesn't work for me.

@SamWhited

This comment has been minimized.

Copy link
Contributor Author

SamWhited commented Jan 29, 2019

@GuillaumeGomez what sort of system are you on or what version of Make? That appears to work for me on both GNUMake and NetBSD make; I think (though I'd have to double check) that that's part of POSIX, so it should work on all versions

EDIT: That may not be true, I don't see any mention of it in the spec after a quick grep. Still, it's widely supported and I've used it a lot when trying to make makefiles more portable, so I'd love to know what version it doesn't exist in. Thanks.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 29, 2019

Linux mint so the problem will be the same on debian and ubuntu as well.

For the Make command version: GNU Make 4.1

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 29, 2019

Ah nevermind. Seems to be working. Don't know what I failed earlier...

@SamWhited

This comment has been minimized.

Copy link
Contributor Author

SamWhited commented Jan 29, 2019

whew I was pretty sure != has been around in GNUMake for a lot longer than 4.1, so I was really getting confused digging through the change log and commits :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 29, 2019

@SamWhited Thanks, Works on windows+msys64 too
👍

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Jan 31, 2019

@GuillaumeGomez, @sdroege IMHO this PR can be merged

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 31, 2019

For me as well, just waiting for @sdroege's opinion on this, just in case.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Jan 31, 2019

Fine with me

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Jan 31, 2019

Then I merge. Thanks @SamWhited !

@GuillaumeGomez GuillaumeGomez merged commit 7c08b9a into gtk-rs:master Jan 31, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@SamWhited SamWhited deleted the SamWhited:bsdmake_support branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.