Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree model sort #777

Merged
merged 4 commits into from Feb 6, 2019

Conversation

Projects
None yet
4 participants
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Feb 5, 2019

Reopening of #721 (I want to have it for next release!). I cherry-picked @ColonelThirtyTwo's commit so his ownership remains.

cc @sdroege @EPashkin

ColonelThirtyTwo and others added some commits Oct 6, 2018

Add bindings for GtkTreeModelSort
Like TreeModelFilter, this object wraps a TreeModel. This model can be sorted without
affecting the ordering of the original model, and can translate sorted TreePaths into
paths to the corresponding unsorted entries.
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 5, 2019

Need use self.as_ref().to_glib_xxx and .unsafe_cast()

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Feb 5, 2019

And to remove an import as well.

@@ -1692,6 +1692,10 @@ status = "generate"
# Replaced by TreeModelFilter::new
ignore = true
[[object.function]]
name = " sort_new_with_model"
# Replaced by TreeModelSort::new
ignore = true

This comment has been minimized.

@sdroege

sdroege Feb 6, 2019

Member

Ah this is placed on the wrong type in the gir file? TreeModel instead of TreeModelSort? Please create an issue in GNOME GitLab and link the issue from here

This comment has been minimized.

@sdroege

sdroege Feb 6, 2019

Member

Link it from inside the .toml file I mean

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Feb 6, 2019

👍

@GuillaumeGomez GuillaumeGomez merged commit 3d936a7 into gtk-rs:master Feb 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:tree-model-sort branch Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.