Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Travis and AppVeyor configurations in sync with the GLib one #779

Merged
merged 1 commit into from Feb 10, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Feb 10, 2019

No description provided.

.travis.yml Outdated
- cargo doc --features "dox"
# catch any sneaked in lgpl docs
- cargo build --features purge-lgpl-docs --jobs 1
- git diff -R --exit-code

This comment has been minimized.

@EPashkin

EPashkin Feb 10, 2019

Member

All test at up need stay

This comment has been minimized.

@sdroege

sdroege Feb 10, 2019

Author Member

You should've said that before all the other ones are merged. I asked if that's fine in the other PRs because the GLib one didn't have any of this and nobody replied to that and then it was merged.

At this point I'd prefer to have all this merged and then we can as a separate step look at what can be improved in the CI configuration. That way it does not go out of sync between all the different repos again.

This comment has been minimized.

@EPashkin

EPashkin Feb 10, 2019

Member

Sorry for missing this.
All crates with embed-lgpl-docs must have tests for it.
Good that cargo allow --features ",v3_16," without any question
cargo test --features "embed-lgpl-docs,$FEATURES" --jobs 1
Please just start write right with this PR.

This comment has been minimized.

@sdroege

sdroege Feb 10, 2019

Author Member

You redo the other ones then? I do gdk and the ones I didn't touch yet still. My patience with CI things is getting to an end :)

For doing things via Docker btw:
https://docs.travis-ci.com/user/docker/
https://hub.docker.com/_/fedora/?tab=tags

Seems a bit more complicated than with gitlab-ci but still manageable. Then we could at least test the latest versions.

This comment has been minimized.

@sdroege

sdroege Feb 10, 2019

Author Member

I do gdk and the ones I didn't touch yet still

I meant gdk-pixbuf, not gdk.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 10, 2019

@EPashkin @GuillaumeGomez that appveyor failure looks transient, can you retry it or just merge?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 10, 2019

Weird error. Let's merge for now. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 69803d6 into gtk-rs:master Feb 10, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 10, 2019

Seems we broke test on win32 again 😢

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 10, 2019

So it wasn't transient? :-/ Urg...

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 10, 2019

We just not tested gtk on apveyor before, maybe because win32 test always fails 😉

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 10, 2019

That might explain it! Haha

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 11, 2019

I think the problem is DLL hell. There seem to be cygwin and mingw DLLs mixed in the PATH here, some of them at least coming from git.

How can this be cleaned up?

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

@EPashkin any ideas? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.