Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acquire the default MainContext when initializing GTK #780

Merged
merged 2 commits into from Feb 10, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Feb 10, 2019

It is required for GTK to be able to own the default main context on the
thread that initialized it, among other things to run its main loop on
that.

Make this more explicit by already acquiring it here during
initialization. This also ensures that other API that checks that this
very thread owns the main context works out of the box.

This depends on gtk-rs/glib#447

sdroege added some commits Feb 10, 2019

Acquire the default MainContext when initializing GTK
It is required for GTK to be able to own the default main context on the
thread that initialized it, among other things to run its main loop on
that.

Make this more explicit by already acquiring it here during
initialization. This also ensures that other API that checks that this
very thread owns the main context works out of the box.
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 10, 2019

Good idea, thanks, 👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 10, 2019

Restarted CI.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 10, 2019

This will be green once #779 is merged.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 10, 2019

Restarted CI.

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 10, 2019

@GuillaumeGomez green apart from appveyor being broken :) I'll fix that later... but it's worrying that gtk tests don't work there. The setup seems broken.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 10, 2019

appveyor worked, travis didn't. Is it expected?

@GuillaumeGomez GuillaumeGomez merged commit 9f614e4 into gtk-rs:master Feb 10, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.