Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xx_sys to xx_ffi renaming #795

Merged
merged 1 commit into from Mar 10, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

commented Mar 6, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

👍

1 similar comment
@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

👍

@EPashkin EPashkin changed the title Remove xx_sys to xx_ffi renaming WIP: Remove xx_sys to xx_ffi renaming Mar 7, 2019

@EPashkin EPashkin force-pushed the EPashkin:ffi_to_sys branch from c730fad to 040c6c1 Mar 7, 2019

@EPashkin EPashkin changed the title WIP: Remove xx_sys to xx_ffi renaming Remove xx_sys to xx_ffi renaming Mar 7, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

This is ready for merge if no problem with travis CI (appveyor 32 will fail again).

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

Brew again do mass remove, trying to fix

@EPashkin EPashkin force-pushed the EPashkin:ffi_to_sys branch from 93c4482 to f906a6c Mar 7, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

Very strange, brew think that libffi installed even after it deleted it.

$ if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew cleanup; fi
Removing: /Users/travis/Library/Caches/Homebrew/libffi-3.2.1.high_sierra.bottle.tar.gz... (97.2KB)
...
Removing: /Users/travis/Library/Logs/Homebrew/libffi... (68B)
...
$ if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install gtk+3 cairo atk libffi; fi
Warning: libffi 3.2.1 is already installed and up-to-date
To reinstall 3.2.1, run `brew reinstall libffi`

Anyone have any idea?

@EPashkin EPashkin force-pushed the EPashkin:ffi_to_sys branch from f906a6c to 040c6c1 Mar 8, 2019

@EPashkin EPashkin force-pushed the EPashkin:ffi_to_sys branch from 040c6c1 to 607c32a Mar 10, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2019

Rebased to solve merge conflict

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

Then I merge. Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 7b2dbba into gtk-rs:master Mar 10, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@EPashkin EPashkin deleted the EPashkin:ffi_to_sys branch Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.