Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: Move trait methods to traits #796

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
4 participants
@sfanxiang
Copy link
Contributor

commented Mar 8, 2019

These methods should be implemented on IsA<Builder>, not just Builder.

@sdroege

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

👍

CI failures are unrelated

@EPashkin

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

@sfanxiang Thanks
👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 81b449e into gtk-rs:master Mar 8, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@sfanxiang sfanxiang deleted the sfanxiang:builder-trait branch Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.