Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version for property FontChooser.level #804

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
3 participants
@EPashkin
Copy link
Member

commented Apr 16, 2019

See comment #794 (comment)

cc @GuillaumeGomez, @sdroege , @martinber

Note not sure that it pass CI's regencheck as I don't updated sub-modules, so better wait for it.

@EPashkin EPashkin force-pushed the EPashkin:fontchooserlevel_version branch from d380139 to b777e37 Apr 16, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

Updated with versions for other 2 new properties

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

@sdroege

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

👍 but why do tests fail?

@sdroege

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

but why do tests fail?

macos travis still broken (@GuillaumeGomez can we just disable that until someone fixes it?), 32 bit Windows still failing the tests for unknown reason.

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

Because we still can't solve problems with apveour32 and travis's OSX.
32bit has due some wrong lib, but I don't know how to find it, see #783
For OSX need specialist on brew to disable removal (I can't find way) or travis rebuild its images with never version.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

I'll work on the travis issue when I'm in Berlin. Meanwhile, just ignore it.

@EPashkin EPashkin force-pushed the EPashkin:fontchooserlevel_version branch from b777e37 to 32ef407 Apr 18, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

Rebased to master, travis passed too, @GuillaumeGomez thanks.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 3e36f74 into gtk-rs:master Apr 18, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:fontchooserlevel_version branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.