Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for GtkApplication to be subclasses #814

Merged

Conversation

Projects
None yet
4 participants
@alatiera
Copy link
Contributor

commented May 12, 2019

This expands further upon the gio MR that does the same
for GApplictiona.

gtk-rs/gio#209

@alatiera alatiera force-pushed the alatiera:alatiera/application-subclass branch from 21f3a4e to 1f52f04 May 12, 2019

}
}

pub trait ApplicationImplExt {

This comment has been minimized.

Copy link
@sdroege

sdroege May 12, 2019

Member

All the traits should probably get Gtk as prefix

This comment has been minimized.

Copy link
@alatiera

alatiera May 12, 2019

Author Contributor

Done :)

@sdroege

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Looks good otherwise :)

@alatiera alatiera force-pushed the alatiera:alatiera/application-subclass branch from 1f52f04 to f22da52 May 12, 2019

Gir.toml Outdated
@@ -426,6 +426,7 @@ status = "generate"
name = "Gtk.Application"
status = "generate"
trait_name = "GtkApplicationExt"
subclassing = true

This comment has been minimized.

Copy link
@EPashkin

EPashkin May 12, 2019

Member

@sdroege This options now not used, can we delete it later?

This comment has been minimized.

Copy link
@sdroege

sdroege May 12, 2019

Member

I guess we can delete it now already :)

This comment has been minimized.

Copy link
@EPashkin

EPashkin May 12, 2019

Member

Ok, I will do it.
@alatiera Please remove this line

This comment has been minimized.

Copy link
@alatiera

alatiera May 12, 2019

Author Contributor

done :)

Allow for GtkApplication to be subclassed
This expands further upon the gio MR that does the same
for GAppliction.

gtk-rs/gio#209

@alatiera alatiera force-pushed the alatiera:alatiera/application-subclass branch from f22da52 to 336b076 May 12, 2019

@sdroege

This comment has been minimized.

Copy link
Member

commented May 13, 2019

@GuillaumeGomez good to go then :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Thanks @alatiera!

@GuillaumeGomez GuillaumeGomez merged commit 4942479 into gtk-rs:master May 13, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.