Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get entry #819

Merged
merged 4 commits into from May 29, 2019

Conversation

Projects
None yet
3 participants
@GuillaumeGomez
Copy link
Member

commented May 26, 2019

Fixes #772.

I was sure that we could handle cast directly inside the "from_glib_*" functions but I was surprised that we couldn't. But I'm wondering with my manual code is the best that we could write. I'm pretty sure I missed something...

cc @sdroege @EPashkin

Show resolved Hide resolved src/entry_completion.rs Outdated
@sdroege

This comment has been minimized.

Copy link
Member

commented May 26, 2019

I was sure that we could handle cast directly inside the "from_glib_*" functions

How would that look like?

Show resolved Hide resolved src/entry_completion.rs Outdated

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:get-entry branch from 7fe585c to b37b64e May 28, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

Updated.

@sdroege

This comment has been minimized.

Copy link
Member

commented May 28, 2019

👍

@EPashkin

This comment has been minimized.

Copy link
Member

commented May 28, 2019

@GuillaumeGomez Thanks and 👍 after regen check fix

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:get-entry branch from b37b64e to ac2a8a4 May 28, 2019

@GuillaumeGomez GuillaumeGomez merged commit 293150b into gtk-rs:master May 29, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:get-entry branch May 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.