Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate init/clear functions for TreeIter, TextIter and Border #825

Merged
merged 2 commits into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

commented Jun 10, 2019

See gtk-rs/gir#793


Needs gtk-rs/glib#496 and the gir PR merged first.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Thanks, 👍

@@ -1781,6 +1780,9 @@ manual_traits = ["TextBufferExtManual"]
[[object]]
name = "Gtk.TextIter"
status = "generate"
init_function_expression = "|_ptr| ()"

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Jun 10, 2019

Member

That is really super ugly... Maybe we should think about an enum?

This comment has been minimized.

Copy link
@sdroege

sdroege Jun 10, 2019

Author Member

How would that enum look like? We somehow need to provide a way to provide a closure here as there are too many different cases.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

There are auto code differences.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

There are auto code differences.

What do you mean?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

The CI error.

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

The CI error.

Yes, that needs the glib PR merged first. Then it succeeds.

@EPashkin

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@sdroege You forgot to update gir submodule too

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

@sdroege You forgot to update gir submodule too

I was waiting with the final update for the GLib PR to be merged so that the CI can succeed then.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Ah sorry, thought that the gir PR was merged!

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

Ah sorry, thought that the gir PR was merged!

The gir PR was, the GLib one not. We need the GLib one for the CI to succeed (and I'll have to update this one, the GTK PR, for the updated gir submodule).

@sdroege sdroege force-pushed the sdroege:init-functions branch from 10ad83c to 51e8b3a Jun 13, 2019

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

As I said on IRC: I don't have time to investigate on how to improve the syntax of this feature for the moment, therefore I'll open a PR and come back to it later if I'm able to find something more "user friendly". The linked issue is here: gtk-rs/gir#794

Thanks @sdroege!

@sdroege

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

@GuillaumeGomez Good to go :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 32f02d5 into gtk-rs:master Jun 13, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.