Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement Builder::connect_signals_full #852
On 20 July 2019 10:35:07 EEST, Xiang Fan ***@***.***> wrote: @sdroege > I assume you tested that it actually works and can be used? :) Maybe worth adding an example to the examples repo? [This example](https://github.com/sfanxiang/gtk-rs-examples4/blob/6ee2e6b3087c01cdc3a766feafb3d5520cd8ca01/src/bin/builder_signal.rs#L25) builds and works. Does it suffice?
I guess so :) can you send a PR for that against the gtk3 examples too? Shouldn't need any code changes In any case, this PR is good to go for me. Unrelated, did you merge back any changes that happened in the gtk3 versions of the crates into the gtk4 versions since you started? Should do that before the first release in any case.…
-- Sent from my Android device with K-9 Mail. Please excuse my brevity.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.