Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subclass: Get started on subclassing GtkWidget #861

Merged
merged 8 commits into from Aug 7, 2019

Conversation

@BrainBlasted
Copy link
Contributor

BrainBlasted commented Aug 5, 2019

Adds support for subclassing GtkWidget and overriding
6 of it's many vfuncs.

Adds support for subclassing GtkWidget and overriding
6 of it's many vfuncs.
src/subclass/widget.rs Outdated Show resolved Hide resolved
src/subclass/widget.rs Outdated Show resolved Hide resolved
src/subclass/widget.rs Outdated Show resolved Hide resolved
src/subclass/widget.rs Outdated Show resolved Hide resolved
src/subclass/widget.rs Outdated Show resolved Hide resolved
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 5, 2019

Good work :)

@BrainBlasted

This comment has been minimized.

Copy link
Contributor Author

BrainBlasted commented Aug 5, 2019

Pushed support for one more vfunc, will get started on the review

src/subclass/widget.rs Outdated Show resolved Hide resolved
BrainBlasted added 4 commits Aug 5, 2019
More work on the signals API needs to be done in order
for this to be useable.
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 5, 2019

Looks good to me, good to be merged and then we only need an example :)

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Aug 6, 2019

@BrainBlasted Thanks

@BrainBlasted BrainBlasted mentioned this pull request Aug 6, 2019
7 of 82 tasks complete
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 7, 2019

@BrainBlasted Do you want to add draw or should we get this in for now?

@BrainBlasted

This comment has been minimized.

Copy link
Contributor Author

BrainBlasted commented Aug 7, 2019

Can we get this in for now?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 7, 2019

Sure. Thanks! (CI failures are spurious)

@GuillaumeGomez GuillaumeGomez merged commit 31fe389 into gtk-rs:master Aug 7, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.