Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subclass: Add subclassing for GtkContainer #865

Merged
merged 1 commit into from Aug 11, 2019

Conversation

@BrainBlasted
Copy link
Contributor

BrainBlasted commented Aug 10, 2019

Currently ommitted vfuncs:

  • composite_name
  • set_child_property
  • get_child_property
Currently ommitted vfuncs:

* composite_name
* set_child_property
* get_child_property
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 10, 2019

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 11, 2019

composite_name

What's complicated with this one? But it's deprecated since 3.10, so maybe we shouldn't add it at all anyway :)

  • set_child_property

  • get_child_property

These are very interesting. I don't know how to properly bind or use them because of the integer property id. Do you happen to know some implementations (in C) of those two virtual methods?

@BrainBlasted

This comment has been minimized.

Copy link
Contributor Author

BrainBlasted commented Aug 11, 2019

What's complicated with this one? But it's deprecated since 3.10, so maybe we shouldn't add it at all anyway :)

Nothing particularly complicated - I was just too tired to work on it at the time :)

I can look for implementations.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 11, 2019

Nothing particularly complicated - I was just too tired to work on it at the time :)

That's fine, let's just ignore that one then as it's deprecated anyway :)

For the others, if you find implementations I can probably figure out how to bind them.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 11, 2019

Also of course fine to just omit the other two for now too, and simply create an issue to track that. They don't seem super useful.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 11, 2019

Looks good to me otherwise, thanks!

@BrainBlasted

This comment has been minimized.

Copy link
Contributor Author

BrainBlasted commented Aug 11, 2019

Made the issue: #867

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 11, 2019

@GuillaumeGomez good to go for me then :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 11, 2019

Thanks @BrainBlasted !

@GuillaumeGomez GuillaumeGomez merged commit 2b77869 into gtk-rs:master Aug 11, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.