Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boxing in async func #866

Merged
merged 1 commit into from Aug 19, 2019
Merged

Fix boxing in async func #866

merged 1 commit into from Aug 19, 2019

Conversation

@EPashkin
Copy link
Member

EPashkin commented Aug 10, 2019

@EPashkin EPashkin force-pushed the EPashkin:regen branch from 3fd0986 to e3587a4 Aug 10, 2019
@EPashkin EPashkin force-pushed the EPashkin:regen branch from e3587a4 to 9ad966c Aug 15, 2019
@EPashkin EPashkin changed the title WIP: Fix boxing in async func Fix boxing in async func Aug 15, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 16, 2019

Seems it depends on gtk-rs/gio#232

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 17, 2019

Restarted CI

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 17, 2019

Strange error repeated, I don't understand why it was not in gio travis.

Also this code on line 478

  --> /home/travis/.cargo/git/checkouts/gio-a4b825b310a073b9/1b2740a/src/auto/app_info.rs:863:25

    |

863 |         let uris = uris.map(ToOwned::to_owned);

    |                         ^^^

    |

    = note: the method `map` exists but the following trait bounds were not satisfied:

            `&mut &[&str] : std::iter::Iterator`

            `&mut [&str] : std::iter::Iterator`
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 19, 2019

I restarted CIs.

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Aug 19, 2019

CI passed

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 19, 2019

👍

cc @sdroege

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 19, 2019

👍 Also as green as it goes, @GuillaumeGomez

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 19, 2019

Thanks @EPashkin !

@GuillaumeGomez GuillaumeGomez merged commit e818d2d into gtk-rs:master Aug 19, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin EPashkin deleted the EPashkin:regen branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.