Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subclassing GtkBin and GtkEventBox #869

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@BrainBlasted
Copy link
Contributor

BrainBlasted commented Aug 11, 2019

No description provided.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 11, 2019

👍 Thanks!

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 11, 2019

Please rebase. Once done and when CI is happy, then I merge.

gtk::BinClass has no vfuncs, so it's just an empty Impl trait
and blank `override_vfuncs()`.
Like bin this is an empty trait & `override_vfuncs()`.
@BrainBlasted BrainBlasted force-pushed the BrainBlasted:bin-eventbox-subclass branch from 03e8c46 to 0fbc54e Aug 11, 2019
@BrainBlasted

This comment has been minimized.

Copy link
Contributor Author

BrainBlasted commented Aug 11, 2019

@BrainBlasted

This comment has been minimized.

Copy link
Contributor Author

BrainBlasted commented Aug 11, 2019

The CI failures don't seem to have anything to do with my changes.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 12, 2019

The CI failures don't seem to have anything to do with my changes.

Yeah all creates need to be updated for an API change in glib :)

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 12, 2019

@GuillaumeGomez Good to go

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 12, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit b14cfc0 into gtk-rs:master Aug 12, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.