Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value get result #870

Merged
merged 5 commits into from Aug 12, 2019
Merged

Value get result #870

merged 5 commits into from Aug 12, 2019

Conversation

@fengalin
Copy link
Contributor

fengalin commented Aug 12, 2019

@fengalin fengalin mentioned this pull request Aug 12, 2019
40 of 43 tasks complete
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 12, 2019

👍

1 similar comment
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 12, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 12, 2019

@GuillaumeGomez no need to wait for CI btw. But once this is in the examples PR will be green again finally :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 12, 2019

Euuuuh... Still need to confirm for syntax check so I'll wait for failure in any case.

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Aug 12, 2019

Sorry for the last-minute change...

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 12, 2019

No need to apologize for code improvements.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 12, 2019

Need to run cargo fmt :)

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Aug 12, 2019

Need to run cargo fmt :)

You mean, for the manual implementations?

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 12, 2019

You mean, for the manual implementations?

A previous PR was merged without cargo fmt, yes.

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Aug 12, 2019

Shall I add a commit here for that?

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 12, 2019

Yeah, another commit on top of yours. Then the CI is at least in theory green here :)

@fengalin fengalin force-pushed the fengalin:value_get_result branch from 44ebcbb to a4da1a4 Aug 12, 2019
@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Aug 12, 2019

I forgot to rebase... That's why it didn't show up before.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 12, 2019

Yay, now we can get it in :)

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Aug 12, 2019

\o/ @GuillaumeGomez let's click!

@fengalin

This comment has been minimized.

Copy link
Contributor Author

fengalin commented Aug 12, 2019

Note: Appveyor / Windows 32bits keeps on failing on cargo test with a rather unexplicit symptom:

error: test failed, to rerun pass '--lib'
Command exited with code -1073741511

The other platforms (including Appveyor / Windows 64bits) don't show this behaviour. See also: gtk-rs/glib#513 (comment)

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Aug 12, 2019

Known problem, the Windows CI is broken.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 12, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 1aa04e0 into gtk-rs:master Aug 12, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@fengalin fengalin deleted the fengalin:value_get_result branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.