Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShortcutLabel #885

Merged
merged 3 commits into from Aug 31, 2019
Merged

ShortcutLabel #885

merged 3 commits into from Aug 31, 2019

Conversation

@jangernert
Copy link
Contributor

jangernert commented Aug 31, 2019

follow up to #884

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Aug 31, 2019

@jangernert Thanks, but CI will nags until submodule gir-files will not updated

@jangernert

This comment has been minimized.

Copy link
Contributor Author

jangernert commented Aug 31, 2019

@EPashkin I'm not sure what you mean by that. Anything I still need to do? Or do we just have to wait until the CI bot has the newest commit of gir-files available to it?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 31, 2019

There is no bot. You're supposed to update it. :)

@jangernert

This comment has been minimized.

Copy link
Contributor Author

jangernert commented Aug 31, 2019

@GuillaumeGomez like this? Anything still missing?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 31, 2019

I think you're done. Let's just wait for CI confirmation then we'll review.

@jangernert

This comment has been minimized.

Copy link
Contributor Author

jangernert commented Aug 31, 2019

Ping

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 31, 2019

Looks good to me.

cc @EPashkin @sdroege

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Aug 31, 2019

@jangernert Thanks
👍

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Aug 31, 2019

Thanks @jangernert !

@GuillaumeGomez GuillaumeGomez merged commit af29917 into gtk-rs:master Aug 31, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jangernert

This comment has been minimized.

Copy link
Contributor Author

jangernert commented Aug 31, 2019

@jangernert jangernert deleted the jangernert:shortcut_label branch Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.