Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder use implemented interfaces properties #894

Merged
merged 1 commit into from Sep 21, 2019

Conversation

@EPashkin
Copy link
Member

EPashkin commented Sep 14, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Sep 17, 2019

Updated with using child configs, also changed many "ignore=true" for properties.

@@ -127,7 +127,6 @@ pub struct AboutDialogBuilder {
parent: Option<Container>,
receives_default: Option<bool>,
sensitive: Option<bool>,
//style: /*Unknown type*/,

This comment has been minimized.

Copy link
@EPashkin

EPashkin Sep 17, 2019

Author Member

Deprecated property and type

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Sep 21, 2019

Member

Shouldn't we handle it like we do with functions? Like adding the deprecated attribute starting from a given version and remove it from the version it got removed?

This comment has been minimized.

Copy link
@EPashkin

EPashkin Sep 21, 2019

Author Member

It was deprecated in 3.0: https://developer.gnome.org/gtk3/stable/GtkStyle.html#gtk-style-new
so it totally deprecated

This comment has been minimized.

Copy link
@GuillaumeGomez

GuillaumeGomez Sep 21, 2019

Member

Perfect then!

@EPashkin EPashkin force-pushed the EPashkin:builder_interface_props branch from 40cc9fd to 40e2e08 Sep 17, 2019
@EPashkin EPashkin changed the title WIP: Builder use implemented interfaces properties Builder use implemented interfaces properties Sep 17, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Sep 17, 2019

Ready for final review

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Sep 18, 2019

👍

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Sep 19, 2019

CI passed

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Sep 20, 2019

Ping

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Sep 21, 2019

I just have one question but otherwise looks good to me as well!

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Sep 21, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit e21124f into gtk-rs:master Sep 21, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin EPashkin deleted the EPashkin:builder_interface_props branch Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.