Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Uninitialized impl for TargetEntry #899

Merged

Conversation

@sdroege
Copy link
Member

sdroege commented Oct 4, 2019

It used mem::zeroed() and that causes undefined behaviour here. String
and other types can't be simply zeroed here.


This also caused a compiler warning with 1.38.

It used mem::zeroed() and that causes undefined behaviour here. String
and other types can't be simply zeroed here.
@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Oct 4, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Oct 5, 2019

@GuillaumeGomez All green now :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Oct 5, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 4ece335 into gtk-rs:master Oct 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Oct 5, 2019

@sdroege Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.