Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subclass: Always allow to override the vfuns of classes #908

Merged

Conversation

@alatiera
Copy link
Contributor

alatiera commented Nov 5, 2019

No description provided.

@alatiera

This comment has been minimized.

Copy link
Contributor Author

alatiera commented Nov 5, 2019

Will also need to be backported to gtk4 bindings

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 5, 2019

@alatiera alatiera force-pushed the alatiera:alatiera/fix-override-vfuncs branch from 077899a to bc8b092 Nov 5, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 5, 2019

Will also need to be backported to gtk4 bindings

Can you do that or create an issue?

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 5, 2019

👍

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 5, 2019

@alatiera Thanks.
👍 after CI

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Nov 6, 2019

@alatiera alatiera force-pushed the alatiera:alatiera/fix-override-vfuncs branch from bc8b092 to dd1547a Nov 6, 2019
@alatiera

This comment has been minimized.

Copy link
Contributor Author

alatiera commented Nov 6, 2019

Can you do that or create an issue?

Can do after this is merged.

@alatiera cargo fmt is needed: https://travis-ci.org/gtk-rs/gtk/jobs/607720361#L766

Should be good now.

@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 7, 2019

@GuillaumeGomez All green! :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 7, 2019

Thanks

@GuillaumeGomez GuillaumeGomez merged commit e4783ec into gtk-rs:master Nov 7, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.