Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renaming for WidgetExt::set_name and BuildableExt::set_name #917

Merged
merged 2 commits into from Nov 20, 2019

Conversation

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Nov 19, 2019

Fixes #914.

Bound to gtk-rs/gir#873

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:rename branch from cd5683d to b14f03c Nov 19, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 19, 2019

Also for get_name please :)

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Nov 19, 2019

Oh right.

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:rename branch from b14f03c to 473bbbd Nov 19, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 19, 2019

👍 once the gir change is in

@GuillaumeGomez GuillaumeGomez force-pushed the GuillaumeGomez:rename branch from 473bbbd to ecc3156 Nov 20, 2019
@sdroege

This comment has been minimized.

Copy link
Member

sdroege commented Nov 20, 2019

And regen and merge :) @GuillaumeGomez

@GuillaumeGomez

This comment has been minimized.

Copy link
Member Author

GuillaumeGomez commented Nov 20, 2019

Regen is already done. The examples are failing. :) Merging then!

@GuillaumeGomez GuillaumeGomez merged commit 5958d86 into gtk-rs:master Nov 20, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:rename branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.