Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Default for builders #919

Merged
merged 1 commit into from Nov 26, 2019
Merged

Conversation

@EPashkin
Copy link
Member

EPashkin commented Nov 26, 2019

Possible replacement for #905.

cc @antoyo

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 26, 2019

CI pass with just Derive (modulo regen_check).
As I remember @antoyo want derive Clone too, so I try to add it too.
PS. Was in wrong PR 😉

@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 26, 2019

Seems CI like derive Clone too.
@antoyo You prefer with Clone or just derive Default?

@antoyo

This comment has been minimized.

Copy link
Member

antoyo commented Nov 26, 2019

@EPashkin: Both.

@EPashkin EPashkin force-pushed the EPashkin:builder_default branch from e76cb67 to a0c19ce Nov 26, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 26, 2019

Updated

@EPashkin EPashkin changed the title WIP: Derive Default for builders Derive Default for builders Nov 26, 2019
@EPashkin EPashkin force-pushed the EPashkin:builder_default branch from a0c19ce to 32feaec Nov 26, 2019
@EPashkin

This comment has been minimized.

Copy link
Member Author

EPashkin commented Nov 26, 2019

CI passed

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Nov 26, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit 380ff03 into gtk-rs:master Nov 26, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EPashkin EPashkin deleted the EPashkin:builder_default branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.