New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New types #117

Merged
merged 2 commits into from Jul 5, 2018

Conversation

Projects
None yet
4 participants
@GuillaumeGomez
Member

GuillaumeGomez commented Jul 2, 2018

Fixes #74.

I don't think we can yet generate LogAttr struct for the moment but except for this one, we now have a new one.

cc @sdroege @EPashkin

@vhakulinen

This comment has been minimized.

Show comment
Hide comment
@vhakulinen

vhakulinen Jul 4, 2018

The Item needs to expose its Analysis: https://developer.gnome.org/pango/stable/pango-Text-Processing.html#PangoItem-struct

Thats also the only way to get a hold of analysis structure.

vhakulinen commented Jul 4, 2018

The Item needs to expose its Analysis: https://developer.gnome.org/pango/stable/pango-Text-Processing.html#PangoItem-struct

Thats also the only way to get a hold of analysis structure.

@sdroege

This comment has been minimized.

Show comment
Hide comment
@sdroege

sdroege Jul 4, 2018

Member

Should also expose the other fields, read-only

Member

sdroege commented Jul 4, 2018

Should also expose the other fields, read-only

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 4, 2018

Member

Updated.

Member

GuillaumeGomez commented Jul 4, 2018

Updated.

Show outdated Hide outdated src/item.rs
Show outdated Hide outdated src/item.rs
@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 5, 2018

Member

Updated.

Member

GuillaumeGomez commented Jul 5, 2018

Updated.

@EPashkin

This comment has been minimized.

Show comment
Hide comment
@EPashkin

EPashkin Jul 5, 2018

Member

Looks good but IMHO need some squash.

Member

EPashkin commented Jul 5, 2018

Looks good but IMHO need some squash.

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 5, 2018

Member

I'll squash once reviews are done to make your lifes easier. ;)

Member

GuillaumeGomez commented Jul 5, 2018

I'll squash once reviews are done to make your lifes easier. ;)

@GuillaumeGomez

This comment has been minimized.

Show comment
Hide comment
@GuillaumeGomez

GuillaumeGomez Jul 5, 2018

Member

Squashed and tests passed. Merge time!

Member

GuillaumeGomez commented Jul 5, 2018

Squashed and tests passed. Merge time!

@GuillaumeGomez GuillaumeGomez merged commit abd959c into gtk-rs:master Jul 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GuillaumeGomez GuillaumeGomez deleted the GuillaumeGomez:new-types branch Jul 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment