Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Travis and AppVeyor configurations in sync with the GLib one #137

Merged
merged 2 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@sdroege
Copy link
Member

sdroege commented Feb 11, 2019

No description provided.

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 11, 2019

👍

@sdroege sdroege force-pushed the sdroege:travis-xenial branch from fe3a2a4 to b60adae Feb 11, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 11, 2019

$ git diff -R --exit-code
diff --git b/src/prelude.rs a/src/prelude.rs
index 11c1e19..185fc02 100644
--- b/src/prelude.rs
+++ a/src/prelude.rs
@@ -2,4 +2,6 @@
 // See the COPYRIGHT file at the top-level directory of this distribution.
 // Licensed under the MIT license, see the LICENSE file or <http://opensource.org/licenses/MIT>
 
+//! Traits and essential types inteded for blanket imports.
+
 pub use auto::traits::*;
The command "git diff -R --exit-code" exited with 1.

What to do about this?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 11, 2019

Oh it removes things from lib.rs? Hmmmm... Not sure what the good thing to do would be in here...

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 11, 2019

How is this handled in other crates?

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 11, 2019

Is there such a case in any other crates?

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 11, 2019

@GuillaumeGomez strange that it touch lib.rs it in IGNORES

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 11, 2019

Hm, I made mistake again, "prelude.rs" not in IGNORES

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

GuillaumeGomez commented Feb 11, 2019

Mystery solved! :3

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

What IGNORES?

@sdroege sdroege force-pushed the sdroege:travis-xenial branch from b60adae to 293c84a Feb 12, 2019

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

Ah I see.

@EPashkin

This comment has been minimized.

Copy link
Member

EPashkin commented Feb 12, 2019

👍

@sdroege

This comment has been minimized.

Copy link
Member Author

sdroege commented Feb 12, 2019

@GuillaumeGomez GuillaumeGomez merged commit 466d615 into gtk-rs:master Feb 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.