Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pango_language_get_sample_string SIGSEGV #149

Merged

Conversation

Projects
None yet
4 participants
@EPashkin
Copy link
Member

commented May 4, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented May 4, 2019

There other wrong from_glib_full here, Ex. pango_language_from_string

@EPashkin EPashkin force-pushed the EPashkin:pango_language_get_sample_string branch from 608396e to cee312e May 4, 2019

@EPashkin

This comment has been minimized.

Copy link
Member Author

commented May 4, 2019

Updated.
There also wrong from_glib_full for Language itself,
but as it implementation is same as from_glib_none without Drop,
I don't changed this.

I wanted to remove FromGlibPtrFull at all,
but it used in generated Context.get_language

@sdroege

This comment has been minimized.

Copy link
Member

commented May 4, 2019

👍

@Cogitri

This comment has been minimized.

Copy link

commented May 4, 2019

Thanks for fixing it!

@GuillaumeGomez

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Thanks!

@GuillaumeGomez GuillaumeGomez merged commit b57c574 into gtk-rs:master May 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EPashkin EPashkin deleted the EPashkin:pango_language_get_sample_string branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.